From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Sergey Ten <sergey(at)sourcelabs(dot)com>, "'Christopher Kings-Lynne'" <chriskl(at)familyhealth(dot)com(dot)au>, jason(at)sourcelabs(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] Adding \x escape processing to COPY, psql, backend |
Date: | 2005-06-02 01:24:11 |
Message-ID: | 200506020124.j521OBj07023@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Patch applied. Thanks for the COPY \x patch.
---------------------------------------------------------------------------
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > Here is a new version of the three \x hex support patches. I have added
> > > \x for psql variables, which is the last patch.
> >
> > > I have IM'ed with Peter and he is now OK with the idea of supporting \x,
> > > with the underestanding that it doesn't take us any farther away from
> > > compatibility than we are now.
> >
> > Peter may be OK with it, but I object strongly to adding this to SQL
> > literals. This is exactly *not* the direction we want to be going in.
> >
> > I don't really see the point for COPY and psql, either.
>
> We already support \n, \r, \t, and \octal. I don't see any problem with
> improving it. It does not take us any closer or farther away from spec
> compliance.
>
> COPY \x has been requested by several people, and there are actually two
> patches that have been submitted in the past year for this.
>
> As you know, escapes already provide a useful mechanism on COPY and SQL
> strings, and there is a plan I just posted to deal with standards
> issues, but I don't see \x taking us closer or farther from this.
>
> Please explain why this takes us in the wrong direction.
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania 19073
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2005-06-02 01:39:25 | Re: O_DIRECT for WAL writes |
Previous Message | Bruce Momjian | 2005-06-02 01:05:11 | Re: NOLOGGING option, or ? |
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2005-06-02 01:39:25 | Re: O_DIRECT for WAL writes |
Previous Message | Bruce Momjian | 2005-06-02 01:20:06 | Re: COPY fast parse patch |