From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Nicolai Tufar <ntufar(at)gmail(dot)com>, Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org |
Subject: | Re: snprintf causes regression tests to fail |
Date: | 2005-03-02 03:23:18 |
Message-ID: | 200503020323.j223NIC10896@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I think this means it is finding our /port/snprintf(), but when it calls
> > vsnprintf, it must be using some other version, probably the operating
> > system version that doesn't support %lld.
>
> Ya know, I was wondering about that but dismissed it because the
> routines were all declared in the same file. Windows' linker must
> behave very oddly to do this.
>
> Does it help if you flip the order of the snprintf and vsnprintf
> functions in snprintf.c?
Yes, it fixes the problem and I have applied the reordering with a
comment.
I will start working on fixing the large fmtpar allocations now.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-02 04:21:24 | Re: snprintf causes regression tests to fail |
Previous Message | Bruce Momjian | 2005-03-02 02:38:55 | Re: snprintf causes regression tests to fail |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-02 04:21:24 | Re: snprintf causes regression tests to fail |
Previous Message | Bruce Momjian | 2005-03-02 02:38:55 | Re: snprintf causes regression tests to fail |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-02 04:21:24 | Re: snprintf causes regression tests to fail |
Previous Message | Bruce Momjian | 2005-03-02 02:38:55 | Re: snprintf causes regression tests to fail |