| From: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
|---|---|
| To: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Multi-table truncate |
| Date: | 2005-01-26 14:10:38 |
| Message-ID: | 20050126141038.GA4403@surnet.cl |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Hackers,
This is my multi-table truncate patch. Includes doc changes and couple
new regression tests.
Note the following excerpt from the temp regression test:
+ BEGIN;
+ CREATE TEMP TABLE temptest3(col int PRIMARY KEY) ON COMMIT DELETE ROWS;
+ NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "temptest3_pkey" for table "temptest3"
+ CREATE TEMP TABLE temptest4(col int REFERENCES temptest3);
+ COMMIT;
+ ERROR: invalid ON COMMIT and foreign key combination
+ DETAIL: Table "temptest4" references "temptest3", but they don't have the same ON COMMIT setting
I haven't investigated whether we can reject the foreign-key/on-commit
combination at create table time, rather than commit time. Maybe it's
worth doing, but then apparently on-commit-actions is not used a lot
(nobody saw the bug I previously reported).
Please review and consider for application.
Thanks,
--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Las mujeres son como hondas: mientras más resistencia tienen,
más lejos puedes llegar con ellas" (Jonas Nightingale, Leap of Faith)
| Attachment | Content-Type | Size |
|---|---|---|
| truncate-2.patch | text/plain | 33.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-01-26 19:24:38 | Re: Fix for SHGetSpecialFolderPath |
| Previous Message | ITAGAKI Takahiro | 2005-01-26 13:06:46 | Re: WAL: O_DIRECT and multipage-writer |