| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: ON COMMIT and foreign keys |
| Date: | 2004-11-06 05:56:24 |
| Message-ID: | 200411060556.iA65uOB01156@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> > Incidentally ("collateral damage"), the patch modifies the TRUNCATE
> > command so that it can work on multiple tables. In particular, if
> > foreign key references are all internal to the group that's being
> > truncated, the command is allowed.
>
> I think this is a feature addition that you've cleverly managed to
> present as a bug fix ;-). While I like the feature, I've got very
> mixed emotions about applying it this late in beta. The "bug" exists
> in 7.4 but has yet to be reported in the field, which says to me that
> we could leave it unfixed in 8.0 as well. Conservatism would suggest
> holding the change for 8.1. OTOH, multiple TRUNCATE would be a useful
> feature --- it came up just the other day.
>
> Comments anyone?
Alvaro, would you post the patch skipping whitespace changes. As posted
the patch does look very large, as you suggested.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-11-06 05:58:54 | Re: ON COMMIT and foreign keys |
| Previous Message | Bruce Momjian | 2004-11-06 05:49:56 | Re: [PATCHES] psql \! WIN32 cleanup |