Re: Tablespace patch review

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Well, I didn't use tablespaces here so the pg_tablespaces directory is
> > empty, so I can't think of what the tablespace is.
>
> You look in the pg_tablespace catalog for the row with that OID.
>
> > Also, are we calling it pg_tablespaces (plural) rather than
> > pg_tablespace?
>
> I didn't have any particular opinion about that till just now ...
> but now I see that it's a good idea for the pg_tablespaces directory
> (the one that holds all the symlinks) to have a different name from the
> pg_tablespace catalog, especially since the latter has a couple of rows
> that do not correspond to any entries in the former.

If you want something distinct, which I understand, perhaps pg_tblspc.

> I'm not wedded to "pg_tablespaces" as the name in particular, but
> it should not be "pg_tablespace", or we'll suffer the same confusion
> over and over that you just did.

OK.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073