Re: Compiling libpq with VisualC

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Compiling libpq with VisualC
Date: 2004-06-03 00:12:27
Message-ID: 200406030012.i530CRY00642@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian wrote:
>
> I noticed that SYSCONFDIR will also be an issue for relocatable installs
> just like localedir. I will address them in the same way either as an
> environment variable or libpq function call to set the location.

Fixed.

> >
> > fe-connect.c:
> > - pg_config_paths.h isn't available. SYSCONFDIR is already defined so
> > fe-connect.c doesn't need to include that.
> > patch appended

This shouldn't be needed anymore. Where is SYSCONFDIR coming from? Is
it from some Win32 include file? It should only be coming from
pg_config_paths.h now.

> > win32.mak:
> > - pg_config.h must be generated
> > - port/pgstrcasecmp.c is needed
> > - port/path.c is not needed
> > - the current cvs version includes some bogus cr characters, when
> > checking out with wincvs the file will contain several cr cr lf lines
> > which will confuse nmake.
> >
> > Because the last problem might be difficult to handle as diff, I
> > attached win32.mak as complete file, with all cr stripped so it may be
> > committed safely with any cvs client.

Added. Thanks.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2004-06-03 01:25:04 Re: Default Locale in initdb
Previous Message Jonathan Gardner 2004-06-02 21:09:17 Re: process num.

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2004-06-03 04:18:24 Re: [pgsql-hackers-win32] select like...not using index
Previous Message Merlin Moncure 2004-06-02 12:07:23 Re: [pgsql-hackers-win32] select like...not using index

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-03 00:13:20 Re: Libpq ssl fix
Previous Message Bruce Momjian 2004-06-03 00:06:49 Re: Relocatable locale