Skip site navigation (1) Skip section navigation (2)

Re: FW: Timezone library

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>,pgsql-patches(at)postgresql(dot)org
Subject: Re: FW: Timezone library
Date: 2004-04-30 14:27:13
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > 	/usr/include/time.h:104: `pg_timezone' redeclared as different kind of
> > 	symbol
> Your <time.h> really defines "pg_timezone"??  I'm wondering if this is
> an indirect effect of a macro naming collision.

I applied the following patch to allow it to compile on Unix.  I had to
mask the 'timezone' define before including "time.h".

I also pass pkglibdir into the timezone makefile like we do for fmgr so
it will know where to find the timezone database.  This is probably only
an interim solution.  We need a more general fix for lib/ anyway, and
this is basically the same problem (that the lib directory is compiled
into the binary and can't be moved).

With this change it compiles but I get this error:
	zic -d /usr/local/pgsql/share/timezone data/africa data/antarctica
	data/asia data/australasia data/europe data/northamerica
	data/southamerica data/pacificnew data/etcetera data/factory
	data/backward data/systemv data/solar87 data/solar88 data/solar89
	"data/solar87", line 385: too many local time types (rule from
	"data/solar87", line 45)

Magnus doesn't see it on Win32.  

To test, define PGTZ in pg_config.h and set PGTZ=yes in

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2004-04-30 14:55:52
Subject: Re: Call for 7.5 feature completion
Previous:From: Bruce MomjianDate: 2004-04-30 14:23:04
Subject: Re: FW: Timezone library

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-04-30 14:37:46
Subject: Re: FW: Timezone library
Previous:From: Bruce MomjianDate: 2004-04-30 14:23:04
Subject: Re: FW: Timezone library

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group