Re: xlog.c timezone name size

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Korea PostgreSQL Users' Group" <pgsql-kr(at)postgresql(dot)or(dot)kr>
Cc: pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: xlog.c timezone name size
Date: 2004-03-22 04:17:36
Message-ID: 200403220417.i2M4HaZ26598@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches


I have increased the str_time() static variable length to 128. Thanks.

---------------------------------------------------------------------------

Korea PostgreSQL Users' Group wrote:
> On multibyte language locale environment of win32, size of %Z of localtime() function is bigger more then 12 bytes.
>
> so, I suggest that change str_time() function in src/backend/access/transam/xlog.c (2765 line)
>
> buf char array size must be at least 70 bytes (20 bytes = datetime, 50 bytes = tzname of depended local locale(?))
>
> Current str_time() function do not return new line on korean language win32 environment.
> It's same on CJK.
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom.Zschockelt 2004-03-22 06:42:08 compile errors
Previous Message Sailesh Krishnamurthy 2004-03-21 17:35:37 Re: [pgsql-hackers-win32] Sync vs. fsync during

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-03-22 04:38:47 Re: pstrndup()
Previous Message Bruce Momjian 2004-03-22 03:57:33 Re: Another pg_autovacuum patch