Re: minor cleanup in plpgsql.sgml

From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: minor cleanup in plpgsql.sgml
Date: 2003-11-26 03:00:43
Message-ID: 200311252200.43584.xzilla@users.sourceforge.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The reported correction was removing the superfluous full_name varchar (which
Neil Conway also reported a few days back). When i was rewriting the
function, I subconsciously switched the SELECT INTO statement to the (IMHO)
more legible syntax, though nothing was wrong with the previous version of
that statement.

Robert Treat

On Tuesday 25 November 2003 20:30, Christopher Kings-Lynne wrote:
> Ummm - surely the original was correct?
>
> Chris
>
> Robert Treat wrote:
> > Marcos Truchado <mtruchado(at)telefonica(dot)net> reported this on -docs
> > yesterday.
> >
> > Robert Treat
> >
> >
> > ------------------------------------------------------------------------
> >
> > Index: plpgsql.sgml
> > ===================================================================
> > RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/plpgsql.sgml,v
> > retrieving revision 1.29
> > diff -c -r1.29 plpgsql.sgml
> > *** plpgsql.sgml 12 Nov 2003 22:47:47 -0000 1.29
> > --- plpgsql.sgml 25 Nov 2003 14:12:50 -0000
> > ***************
> > *** 986,994 ****
> > <programlisting>
> > DECLARE
> > users_rec RECORD;
> > - full_name varchar;
> > BEGIN
> > ! SELECT INTO users_rec * FROM users WHERE user_id=3;
> >
> > IF users_rec.homepage IS NULL THEN
> > -- user entered no homepage, return "http://"
> > --- 986,993 ----
> > <programlisting>
> > DECLARE
> > users_rec RECORD;
> > BEGIN
> > ! SELECT * FROM users WHERE user_id=3 INTO users_rec;
> >
> > IF users_rec.homepage IS NULL THEN
> > -- user entered no homepage, return "http://"
> >
> >
> > ------------------------------------------------------------------------
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 4: Don't 'kill -9' the postmaster
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html

--
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2003-11-26 04:17:56 make installcheck on non-default ports
Previous Message Claudio Natoli 2003-11-26 01:37:18 Re: Bug in fd.c (FreeFile)