Re: fix log_min_duration_statement logic error

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-09-27 14:30:45
Message-ID: 200309271430.h8REUjq21893@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Yes, I will.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Tom Lane writes:
>
> > Neil Conway <neilc(at)samurai(dot)com> writes:
> > > I also don't particularly like the format of the log message (for one
> > > thing, the "duration_statement" prefix in the log message shouldn't
> > > include an underscore, it's not a variable or anything -- and the case
> > > can be made that if we printed the duration because log_duration is set,
> > > we don't need to print it again if the duration of the query exceeded
> > > log_min_duration_statement), but I haven't changed it.
> >
> > I think there should be just one "duration: nnn" log entry, printed if
> > either condition holds.
>
> Is anyone going to take care of this?
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-09-27 20:35:45 Re: 7.3.4 release note format
Previous Message Peter Eisentraut 2003-09-27 14:06:15 Re: fix log_min_duration_statement logic error