Re: WIN32_CONSOLE usage

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>, christoph(dot)dalitz(at)hs-niederrhein(dot)de, pgsql-cygwin(at)postgresql(dot)org
Subject: Re: WIN32_CONSOLE usage
Date: 2003-09-07 16:34:02
Message-ID: 200309071634.h87GY2P11147@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers-win32 pgsql-patches

Peter Eisentraut wrote:

> c) Problem: 8bit characters were displayed/interpreted wrong in psql
> This is due to the fact that the Win32 "console" uses a
> different encoding than the rest of the Windows system
> Solution: Introduced a new psql variable WIN32_CONSOLE
> When set with "\set WIN32_console", the function OemToChar()

> Bruce Momjian writes:
>
> > Is this a valid feature? Should I document it?
>
> Maybe it's a valid feature, but the implementation is not valid.
> Other applications also make use of the print routines (e.g., createlang),
> and they cannot interactively set variables. So I repeat: the print
> routines may not access the psql settings.
>
> I think we ought to detect the console type automatically anyway.
> Certainly we don't want people to have to set this variables all the time.

Agreed. Automatic is ideal. Any ideas out there?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Bruce Momjian 2003-09-07 16:37:42 Re: [PATCHES] MinGW patch
Previous Message Peter Eisentraut 2003-09-07 16:31:02 Re: [PATCHES] MinGW patch

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2003-09-07 16:37:42 Re: [PATCHES] MinGW patch
Previous Message Peter Eisentraut 2003-09-07 16:31:02 Re: [PATCHES] MinGW patch

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-09-07 16:37:42 Re: [PATCHES] MinGW patch
Previous Message Peter Eisentraut 2003-09-07 16:31:02 Re: [PATCHES] MinGW patch