Re: I want to send comments to the backend!

OK, this patch fixes the comment passing bug. I remove the strspn() and
added a boolean to test if any parsetree had been generated --- if not,
I call NullCommand(). I also changed the call to use 'dest' rather than
a hardwired "Remote".

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> generalize it to understand about comments. Right now seems to be a
> >> fine time to think about this, in fact, given that we're hacking the
> >> protocol anyway.
>
> > Yes.
>
> On third thought, though, it would be really trivial for
> pg_exec_query_string to call NullCommand and fall out early if
> pg_parse_query returns an empty list; it'd take one extra test for NIL,
> which would be more than compensated for if we got rid of the strspn
> test. So maybe changing the backend is the best answer after all.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073