Skip site navigation (1) Skip section navigation (2)

Re: inline newNode()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: inline newNode()
Date: 2002-10-11 23:35:14
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Peter Eisentraut wrote:
> Bruce Momjian writes:
> > Peter Eisentraut wrote:
> > > Bruce Momjian writes:
> > >
> > > > I assume the GEQO results he is seeing is only for a tests, and that the
> > > > macro version of newNode will help in all cases.
> > >
> > > Well are we just assuming here or are we fixing actual problems based on
> > > real analyses?
> >
> > What is your point?  He is testing GEQO, but I assume other places would
> > see a speedup from inlining newNode.
> That's exactly my point: You're assuming.

We know GEQO is faster, and the 8% is enough to justify the inlining. 
Whether it speeds up other operations is assumed but we don't really
care;  the GEQO numbers are enough.  The code bloat is minimal.

> Of course everything would be faster if we inline it, but IMHO that's the
> compiler's job.

Yes, but we have to help it in certain cases, heap_getattr() being the
most dramatic.   Are you suggesting we remove all the macros in our
header file and replace them with function calls?

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2002-10-12 00:06:44
Subject: Re: inline newNode()
Previous:From: Peter EisentrautDate: 2002-10-11 23:07:04
Subject: Re: inline newNode()

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-10-11 23:36:11
Subject: Re: INSTALL updates
Previous:From: Kris JurkaDate: 2002-10-11 23:11:17
Subject: Re: Anoter JDBC Error

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group