Re: contrib/earthdistance missing regression test files

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruno Wolff III <bruno(at)wolff(dot)to>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: contrib/earthdistance missing regression test files
Date: 2002-09-25 03:46:42
Message-ID: 200209250346.g8P3kg204082@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> No. The new files are:
> >> expected/earthdistance.out (which you metion above)
> >> sql/earthdistance.sql
>
> > OK, here's what I see now in CVS:
>
> > #$ pwd
> > /pgtop/contrib/earthdistance
> > #$ lf
> > CVS/ README.earthdistance earthdistance.out
> > Makefile earthdistance.c earthdistance.sql.in
>
> > What should be changed?
>
> The earthdistance.out file should be in an expected/ subdirectory, not
> directly in the contrib/earthdistance directory. Also, there is a
> missing regression input script file earthdistance.sql (this is not
> related to earthdistance.sql.in), which should be in a sql/
> subdirectory.

OK, done. I thought the earthdistance.sql file was derived from
earthdistance.sql.in, and I thought the out was just a test file. I got
them fixed now, in their proper directory. How do I run the regression
tests for /contrib stuff?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-09-25 03:57:29 Re: contrib/earthdistance missing regression test files
Previous Message jra 2002-09-25 02:14:40 Re: PGXLOG variable worthwhile?