Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Proposed GUC Variable

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>,Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Proposed GUC Variable
Date: 2002-08-28 19:11:09
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Larry Rosenman wrote:
> > > 3. Not sure what the "original" is for -- you're not transforming
> > > anything.
> > 
> > Agreed.  Just call it "Error query".  Seems clear to me.
> What about rule(s) transformation(s)?  Will we see the real query or the
> transformed query?

Well, looking at Gavin's patch, I see:

+               if(lev == ERROR && Debug_print_error_query)
+                       elog(LOG,"original query: %s",debug_query_string);

That will be the query supplied by the user.  To give them anything else
would be even more confusing --- "How did that query get executed.  I
don't even see that query in my code".  At least when they see that the
query and the error don't match, they can think, rules/triggers, etc. 
We should mention the possible mismatch in the docs.

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2002-08-28 21:01:25
Previous:From: Neil ConwayDate: 2002-08-28 19:10:57
Subject: Re: @(#)Mordre Labs advisory 0x0005: Several buffer overruns in PostgreSQL

pgsql-patches by date

Next:From: Neil ConwayDate: 2002-08-28 19:47:35
Subject: Re: create or replace rule/view (fwd)
Previous:From: Larry RosenmanDate: 2002-08-28 19:07:57
Subject: Re: [HACKERS] Proposed GUC Variable

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group