Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] [PATCH] Win32 native fixes after SSL updates (+more)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Magnus Naeslund(f)" <mag(at)fbab(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] [PATCH] Win32 native fixes after SSL updates (+more)
Date: 2002-07-18 20:24:17
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

I will try to apply it within the next 48 hours.


Magnus Naeslund(f) wrote:
> Hello, i noticed that win32 native stopped working/compiling after the SSL merge.
> So i took the opportunity to fix some stuff:
> 1. Made the thing compile (typos & needed definitions) with the new pqsecure_* stuff, and added fe-secure.c to the win32.mak makefile.
> 2. Fixed some MULTIBYTE compile errors (when building without MB support).
> 3. Made it do that you can build with debug info: "nmake -f win32.mak DEBUG=1".
> 4. Misc small compiler speedup changes.
> The resulting .dll has been tested in production, and everything seems ok.
> I CC:ed -hackers because i'm not sure about two things:
> 1. In libpq-int.h I typedef ssize_t as an int because Visual C (v6.0) doesn't define ssize_t. Is that ok, or is there any standard about what type should be used for ssize_t? 
> 2. To keep the .dll api consistent regarding MULTIBYTE I just return -1 in fe-connect.c:PQsetClientEncoding() instead of taking away the whole function. I wonder if i should do any compares with the conn->client_encoding and return 0 if nothing would have changed (if so how do i check that?).
> Regards
> Magnus Naeslund
> -- 
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
>  Programmer/Networker [|] Magnus Naeslund
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
[ Attachment, skipping... ]

> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: J. R. NieldDate: 2002-07-18 20:25:07
Subject: Re: Issues Outstanding for Point In Time Recovery (PITR)
Previous:From: Richard TuckerDate: 2002-07-18 19:56:20
Subject: Re: Issues Outstanding for Point In Time Recovery (PITR)

pgsql-patches by date

Next:From: Rod TaylorDate: 2002-07-18 20:29:02
Subject: Re: Between Node
Previous:From: Bruce MomjianDate: 2002-07-18 20:04:55
Subject: Re: Between Node

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group