| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: make BufferGetBlockNumber() a macro |
| Date: | 2002-04-18 02:55:23 |
| Message-ID: | 200204180255.g3I2tOr27140@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Neil Conway wrote:
> On Mon, 01 Apr 2002 20:50:27 -0500
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> writes:
> > > C's information hiding is weak enough that you need to rely on the
> > > client programmer to exercise good judgement anyway;
> >
> > This is not a good argument for making the hiding even weaker. I still
> > object to this patch.
>
> Ok. The attached trivial patch removes some obsolete or incoherent
> comments and fixes an assertion in BufferGetBlockNumber. The
> macro-ization of BufferGetBlockNumber is _not_ included.
>
> Please apply.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Larry Rosenman | 2002-04-18 03:14:20 | Re: [HACKERS] build of 7.2.1 on SCO Openserver and |
| Previous Message | Larry Rosenman | 2002-04-18 01:25:27 | Re: [HACKERS] build of 7.2.1 on SCO Openserver and |