| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Rod Taylor <rbt(at)zort(dot)ca> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, Hackers List <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] YADP - Yet another Dependency Patch |
| Date: | 2002-04-16 05:15:11 |
| Message-ID: | 200204160515.g3G5FBp12923@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Rod Taylor wrote:
> [ copied to hackers ]
>
> > 1. I don't like the code that installs and removes ad-hoc
> dependencies
> > from relations to type Oid. On its own terms it's wrong (if it were
Looks good to me. I realize this is a huge chunk of code. The only
ultra-minor thing I saw was the use of dashes for comment blocks when
not needed:
/* ----
* word
* ----
*/
We use dashes like this only for comments that shouldn't be reformatted
by pgindent.
The one thing I would like to know is what things does it track, and
what does it not track? Does it complete any TODO items, or do we save
that for later?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gavin Sherry | 2002-04-16 05:17:25 | Re: Importing Large Amounts of Data |
| Previous Message | Manuel Sugawara | 2002-04-16 05:11:50 | Re: regexp character class locale awareness patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Inoue | 2002-04-16 05:23:48 | Re: ANSI Compliant Inserts |
| Previous Message | Bruce Momjian | 2002-04-16 05:06:50 | Re: [PATCHES] [SQL] 16 parameter limit |