Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] YADP - Yet another Dependency Patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rod Taylor <rbt(at)zort(dot)ca>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org,Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] YADP - Yet another Dependency Patch
Date: 2002-04-16 05:15:11
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
Rod Taylor wrote:
> [ copied to hackers ]
> > 1. I don't like the code that installs and removes ad-hoc
> dependencies
> > from relations to type Oid.  On its own terms it's wrong (if it were

Looks good to me.  I realize this is a huge chunk of code.  The only
ultra-minor thing I saw was the use of dashes for comment blocks when
not needed:

	/*  ----
	 *  word
	 *  ----

We use dashes like this only for comments that shouldn't be reformatted
by pgindent.

The one thing I would like to know is what things does it track, and
what does it not track?  Does it complete any TODO items, or do we save
that for later?

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to


pgsql-hackers by date

Next:From: Gavin SherryDate: 2002-04-16 05:17:25
Subject: Re: Importing Large Amounts of Data
Previous:From: Manuel SugawaraDate: 2002-04-16 05:11:50
Subject: Re: regexp character class locale awareness patch

pgsql-patches by date

Next:From: Hiroshi InoueDate: 2002-04-16 05:23:48
Subject: Re: ANSI Compliant Inserts
Previous:From: Bruce MomjianDate: 2002-04-16 05:06:50
Subject: Re: [PATCHES] [SQL] 16 parameter limit

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group