From: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: ALT*R T*BL* S*T / DR*P N*T N*LL patch - 4th try |
Date: | 2002-03-31 05:35:00 |
Message-ID: | 20020331133339.R82404-100000@houston.familyhealth.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
> This looks good but I'm afraid it's out of step with recent changes
> for schema support. In particular, heap_openr is now The Wrong Thing
> to use for anything except access to system relations. As of CVS tip,
> all the AlterTable routines use OID parameters not name parameters
> to identify the table to work on. Could I ask you to update the patch
> to match the coding style in CVS tip?
Yep - already done - I was just about to resubmit it.
> > The only thing I haven't checked are my ecpg changes. I would like someone
> > with more ecpg experience to check my preproc.y changes.
>
> I'd suggest leaving ecpg to Michael; he seems to prefer to do those
> updates himself.
Hmmm...I'll just leave it out then i guess...
Regards,
Chris
From | Date | Subject | |
---|---|---|---|
Next Message | Christopher Kings-Lynne | 2002-03-31 05:41:48 | Nullability patch take 2 |
Previous Message | Rod Taylor | 2002-03-31 03:22:39 | Re: Insert ... (a, b, DEFAULT, c, d); |