Skip site navigation (1) Skip section navigation (2)


From: Jean-Michel POURE <jm(dot)poure(at)freesurf(dot)fr>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: ALTER VIEW
Date: 2002-02-23 18:30:09
Message-ID: 200202231830.g1NIU9FP020185@www1.translationforge (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
Hi Dave,

I commited some changes to CVS. Now, I need more info to understand :

> 1) Don't create the view twice, create the fake one then rename it - it's
> less expensive and avoids the potential for the second create to fail.

> 2) The szOldDefintion stuff can now be removed.

> 3) The OID and Definition could be retrieved in one operation rather than
> 2.

> 4) A class library such as this should _never_ display any user interface.
> That is the job of the application.
I agree. Could you outline the code, please?

> 5) The modifications to the SQL property are messy & mainly unnecessary
> (certainly with #1 above - that just needs bDrop & szViewName).

On the converse, I think it is a very powerfull way to write SQL code. 
Actually, I was going to ask you to apply this kind of modification to all 
SQL clauses in pgSchema.

SQL (bDrop, bCreate, bACL, bComment, ....) is quite straightforward. In the 
future, we could ask a distinct object to build SQL queries, with batch 
processing and transactions. This would be very powerfull and would allow the 
querying of MySQL, MSsql server, etc... OK, let's not go so far, I am a 

Also, I would like to point out there should not be any SQL code in Views, 
Tables, etc.. All should be performed at object level in pgViews, pgTables, 
pg** using ***precisely the new SQL clause. The less SQL we write by hand, 
the easier we will maintain pgAdmin2.

> 6) The iLogEvent "Entering..." code should be immediately after the On
> Error code, not in the middle of the function.

> 7) The Comment cache is not being invalidated.
Why should I invalidate comment cache? The fake view was created with 
comments and acl. Do I miss something?

B. Triggers
The new code allows to move a trigger from one table to another. How can I 
refresh display after modification?

By the way, should I CC you or not? pgadmin_hackers is sometimes too slow
for discussion.


In response to

  • ALTER VIEW at 2002-02-22 22:06:52 from Dave Page

pgadmin-hackers by date

Next:From: Jean-Michel POUREDate: 2002-02-23 19:59:25
Subject: Schema unique stamp (OID, MD5?)
Previous:From: Dave PageDate: 2002-02-22 22:24:50
Subject: Re: ALTER VIEW

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group