Skip site navigation (1) Skip section navigation (2)

Re: More problem with scripts

From: Brent Verner <brent(at)rcfile(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: More problem with scripts
Date: 2002-01-04 00:50:23
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
[2002-01-03 23:33] Peter Eisentraut said:
| > Brent Verner wrote:
| > > [2002-01-03 14:19] Bruce Momjian said:
| > > | 
| > > | Actually, we can just do:

| > > +1
| > > 
| > >   I can't see a reason to /not/ fix something this simple for the 7.2 
| > > release.  In general, I think it's best to fix things like this[1]
| > > "on sight" as opposed to queueing them in TODO where they /might/ sit
| > > untouched through another release cycle.
| > > 
| > > [1] meaning problems that require little effort to fix, and whose
| > >     solutions are /very/ localized.
| > 
| > OK, one more +1 and I will get to it.
| -4

  Hey, no ballot stuffing ;-)

| 1: It's not a regression from 7.1.  Anything else is too late.

  IMO, this is not a valid reason to /not/ fix _this problem_.  Taken 
to an extreme, this reasoning would allow any number of fatal bugs to
remain in 7.2 because they also existed in 7.1.  Given the imminent
release, this position is valid even for a number of non-fatal bugs, 
but not this one.

| 2: The issue does not cause problems if you stick to the documented syntax
| and it
|    does not cause hazard if you don't.

  First half correct.  It is arguable whether or not the following
would be considered a hazard or not.  Is unexpected behavior 

$ createdb whatiwanted whatigot

| 3: The patch is wrong, because showing the usage screen in case of an error
| is
|    inappropriate.

  Perhaps a more suitable message similar to the "invalid option" error
should be printed prior to exit, but this is not as important as 
enforcing proper/documented use of the script(s).


"Develop your talent, man, and leave the world something. Records are 
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing."  -- Duane Allman

In response to


pgsql-hackers by date

Next:From: Tom LaneDate: 2002-01-04 01:02:54
Subject: Re: LWLock contention: I think I understand the problem
Previous:From: Tom LaneDate: 2002-01-03 23:39:59
Subject: Re: LWLock contention: I think I understand the problem

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group