Re: make createlang match docs

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Kreen <marko(at)l-t(dot)ee>, pgsql-patches(at)postgresql(dot)org
Subject: Re: make createlang match docs
Date: 2002-01-03 05:33:04
Message-ID: 200201030533.g035X4u10465@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Marko Kreen <marko(at)l-t(dot)ee> writes:
> > * make createlang match docs: "createlang dbname" did not work.
>
> Unless you can demonstrate that createlang changed behavior recently,
> this is the wrong fix. Breaking existing scripts that use createlang
> is not the way to go; fixing the documentation to match the code is
> the way to go.

Actually, the existing code didn't work. The options part had dbname as
optional, but the later code only tested for an optional langname;
clearly a mess.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-01-03 05:43:06 Re: make createlang match docs
Previous Message Bruce Momjian 2002-01-03 05:29:27 Re: make createlang match docs