Skip site navigation (1) Skip section navigation (2)

Re: TODO question

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Pavlo Baron <pb(at)pbit(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TODO question
Date: 2001-12-29 03:44:50
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
> Bruce Momjian writes:
> > Sure, ask away.  We will do our best.  In fact, adding a new node is
> > pretty tricky.  There is a developer's FAQ item about it, number 7.  I
> > assume you read that already.
> you mean the current version of FAQ on the web? there are 2 seventh
> items in the table of contents, both jumping to
> ----------------------------------------snip--------------------------------
> -
> 7) I just added a field to a structure. What else should I do?
> The structures passing around from the parser, rewrite, optimizer, and
> executor require quite a bit of support. Most structures have support
> routines in src/backend/nodes used to create, copy, read, and output those
> structures. Make sure you add support for your new field to these files.
> Find any other places the structure may need code for your new field. mkid
> is helpful with this (see above).
> ----------------------------------------snap--------------------------------
> -
> Is that what you mean? It confuses me a bit, surely because I'm new here...
> I didn't change any existing struct, and coudn't find any struct I which
> could grow bacause of my new parsenode type. The type-enum contains a
> corresponding range of values (I think, it was smth. starting with 700 upto
> ...) - I just added my new type here.
> Or do I use a wrong copy of FAQ?

Yes, that is the one.  The steps for adding an entry to an existing
structure is similar to add an entirely new one.

> > I may be able to take you patch and add the needed node support stuff,
> > and send the patch back to you so you can continue on it.
> thanx. please, feel free - I attached my last patch to this email.
> I see, that my patch provides the needed operation, but maybe it's not
> enough and could cause some side effects. I'm looking forward to your
> modifications (I hope it doesn't keep you from your current work, at least
> not crucial). What I'm just interested in is, if my changes would be a
> subset of your code or if what I did is an absolute b*-sh* ,)

I think it would be a subset.  I haven't looked at it closely yet,

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to


pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-12-29 03:51:06
Subject: Re: TODO question
Previous:From: Thomas LockhartDate: 2001-12-29 03:39:42
Subject: date/time formats in 7.2

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group