Re: use GUC for cmdline

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Marko Kreen <marko(at)l-t(dot)ee>, pgsql-patches(at)postgresql(dot)org
Subject: Re: use GUC for cmdline
Date: 2001-06-19 23:41:11
Message-ID: 200106192341.f5JNfBB21328@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Now that I look at it, this patch is pretty broken. For one, calling
> > SetConfigOption("option_name", optarg, PGC_POSTMASTER, true);
> > when the option letter doesn't take an argument is surely wrong.
>
> > Hint: Try 'postmaster -i'.
>
> Also try
> postmaster -o -F
> which has always worked in the past. Now it causes backends to fail
> to start up, saying
> FATAL 1: 'fsync' cannot be changed now

OK, I have backed out the patch and attached it here. Marko, can you
fix the problems and resubmit? Thanks.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 18.7 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-06-19 23:46:02 Re: possible patch to increase number of hash overflow pages?
Previous Message Tom Lane 2001-06-19 21:58:48 Re: use GUC for cmdline