Re: Re: [INTERFACES] Postgres odbc driver bug

> Bruce Momjian wrote:
> >
> > OK, I have created a context diff of your changes, which is
> attached.
> > Can someone comment on this? The patch appears to deal with
> > STMT_PREMATURE differently than our current code.
> >
> > In fact, it seems to disable this code:
> >
> > /*
> > * If the statement is premature, it means we already executed it from
> > * an SQLPrepare/SQLDescribeCol type of scenario. So just return
> > * success.
> > */
> > if (stmt->prepare && stmt->status == STMT_PREMATURE)
> >
>
> Though this fixes the bug reported by Keith, STMT_PREMATURE
> loses its meaning and SC_pre_execute() does a non-essential
> work as a result. Possibly SQLPrepare() must be rewritten
> though I'm not sure.

OK, I see you have applied your patch:

1) [ODBC] Psqlodbc and Centura: here it is a patch
posted by Matteo Cavalleli
2) [ODBC] pgsqODBC binding parameters II
posted by Ludek Finstrle
3) Invalid Page Fault in PSQLODBC.DLL
personal mail from Johann Zuschlag

I removed it from the outstanding patches page.

And you are saying that this patch fixes a different problem. The user
reported his problems were fixed by that patch, so I am inclined to
apply it.

Thanks.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026