Re: Small xlog.c cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Matthew Kirkwood <matthew(at)hairy(dot)beasts(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Small xlog.c cleanup
Date: 2001-02-27 18:07:28
Message-ID: 200102271807.NAA21287@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> On Tue, 27 Feb 2001, Bruce Momjian wrote:
>
> > All source gets reformatted before release by src/tools/pgindent
> > anyway.
>
> This is more than just a formatting change -- it turns
> some static globals into static locals.
>
> Sorry, I should have been a little more verbose in my
> description.

Can you point me to the change. I don't see it:

---------------------------------------------------------------------------

-static int readFile = -1;
-static uint32 readId = 0;
-static uint32 readSeg = 0;
-static uint32 readOff = 0;
static char readBuf[BLCKSZ];
static XLogRecord *nextRecord = NULL;

@@ -1214,6 +1210,10 @@
bool nextmode = (RecPtr == NULL);
int emode = (nextmode) ? LOG : STOP;
bool noBlck = false;
+ static int readFile = -1;
+ static uint32 readId = 0;
+ static uint32 readSeg = 0;
+ static uint32 readOff = 0;

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message The Hermit Hacker 2001-02-27 18:31:35 Re: Small xlog.c cleanup
Previous Message Matthew Kirkwood 2001-02-27 17:29:54 Re: Small xlog.c cleanup