Re: Recent patch to DatabaseMetaData

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter T Mount <peter(at)retep(dot)org(dot)uk>
Cc: Bruce Momjian - CVS <momjian(at)hub(dot)org>, INVALID_ADDRESS(at)(dot)SYNTAX-ERROR, pgsql-committers(at)postgresql(dot)org
Subject: Re: Recent patch to DatabaseMetaData
Date: 2001-02-13 14:52:08
Message-ID: 200102131452.JAA23956@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

[ Charset ISO-8859-1 unsupported, converting... ]
>
> I missed the commit message about 3 days ago to the file
> src/interfaces/jdbc/org/postgresql/jdbc2/DatabaseMetaData.java
>
> Can it be backed out please and the patch sent to me? I've got a commit that's
> failing and there's a lot of methods in that class that have now changed (ie:
> JDBC will now report that outer joins are now possible) and there's the
> TestCase for that class that can't go in because it reports the wrong
> information.

Here is the patch. I applied it to DatabaseMetaData.java in postgresql/
and jdbc1 and jdbc2. It was a cleanup of the code to no longer handle
large object files, because they are all stored in a single table now.

Hard to imagine that caused the problems you reported. I can back it
out, but it hits a couple of files. Please let me know. Recent logs
for that file are:

revision 1.12
date: 2001/02/09 22:23:47; author: momjian; state: Exp; lines: +4 -6
Remove last code that assumed xinv/xinx are large object files.
----------------------------
revision 1.11
date: 2001/01/24 09:22:01; author: peter; state: Exp; lines: +251
-251
Removed the 8k row limit reported by DatabaseMetaData
----------------------------
revision 1.10
date: 2000/11/25 04:32:12; author: momjian; state: Exp; lines: +8 -8
Allow jdbc to return proper server version number

Anders Bengtsson
----------------------------

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 2.1 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter T Mount 2001-02-13 15:17:25 Re: Recent patch to DatabaseMetaData
Previous Message Bruce Momjian - CVS 2001-02-13 14:33:51 pgsql/src/test/regress/expected abstime-1947-P ...