| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Michael C(dot) Thornburgh" <zenomt(at)armory(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Re: patch for src/backend/main/main.c |
| Date: | 2001-01-24 05:24:21 |
| Message-ID: | 200101240524.AAA09108@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Comment added.
> "Michael C. Thornburgh" <zenomt(at)armory(dot)com> writes:
> >> We already use strdup a lot. Want to send a new patch?
>
> > attached is take-2 of a patch which fixes a bug related
> > to the use of getpwuid when running in standalone mode.
>
> I should have mentioned one more request, which is a comment
> in the code explaining just *why* the strdup is needed.
> Otherwise somebody will delete it someday.
>
> Bruce already applied your v2 patch, but if you can offer
> a one-or-two-line summary suitable for insertion as a comment,
> it'd be appreciated.
>
> regards, tom lane
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 846 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Cedar Cox | 2001-01-24 09:52:22 | Re: Re: [INTERFACES] Re: more odbc patches |
| Previous Message | Bruce Momjian | 2001-01-24 05:07:39 | Re: [PATCHES] Small patch to replace 'idle' by 'trans' if transactionis still open |