Re: binary operators on integers

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: binary operators on integers
Date: 2000-10-17 04:00:51
Message-ID: 200010170400.AAA06830@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Can someone comment on this?

> Here is my next take on binary operators for integers.
> It implements the following operators for int2/int4/int8:
>
> ~ - not
> & - and
> ^ - xor
> | - or
> << - shift left
> >> - shift right
>
> Notes:
>
> * My original choice for xor was '#' because the '^' operator conflicts
> with power operator on floats but Tom Lane said:
>
> > Well, you *could* use '^' since there's no definition of it for integer
> > operands. But that would mean that something like '4^2', which was
> > formerly implicitly coerced to float and interpreted as floating
> > power function, would suddenly mean something different. Again a
> > serious risk of silently breaking applications. This doesn't apply to
> > '|' though, since it has no numeric interpretation at all right now.
>
> As the bit-string uses '^' too for xor-ing it would be nice to be
> consistent. I am quite unsure on this matter. The patch now seems
> otherwise sane to me, this is the only issue left.
>
> * On << and >> the second argument is always int32 as this seems
> to be the 'default' int type in PostgreSQL.
>
> * Oids used are 1874 - 1909.
>
> Comments?
>
> Patch is against current CVS.
>
> --
> marko
>

[ Attachment, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2000-10-17 04:02:22 Re: [COMMITTERS] pgsql/src/backend/utils/adt (formatting.c oracle_compat.c)
Previous Message Tom Lane 2000-10-17 04:00:24 Re: The lightbulb just went on...

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2000-10-17 04:07:32 Re: binary operators on integers
Previous Message Bruce Momjian 2000-10-17 03:42:49 Re: Network Patch to specify IP Address to Bind to