Skip site navigation (1) Skip section navigation (2)

Re: when does CREATE VIEW not create a view?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>
Cc: t-ishii(at)sra(dot)co(dot)jp, pgsql-hackers(at)hub(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: when does CREATE VIEW not create a view?
Date: 2000-10-15 03:39:03
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
I hate to say this, but this patch fails to apply on our current tree. 
Can you send me a version that applies?  Thanks.

> On Tue, Aug 29, 2000 at 10:12:38AM +0900, t-ishii(at)sra(dot)co(dot)jp wrote:
> > > > Oh, the patch strikes me since it is not "multibyte aware."
> O.K. - 
> Here's the multibyte aware version of my patch to fix the truncation
> of the rulename autogenerated during a CREATE VIEW. I've modified all
> the places in the backend that want to construct the rulename to use
> the MakeRetrieveViewRuleName(), where I put the #ifdef MULTIBYTE, so
> that's the only place that knows how to construct a view rulename. Except
> pg_dump, where I replicated the code, since it's a standalone binary.
> The only effect the enduser will see is that views with names len(name)
> > NAMEDATALEN-4 will fail to be created, if the derived rulename clases
> with an existing rule: i.e. the user is trying to create two views with
> long names whose first difference is past NAMEDATALEN-4 (but before
> NAMEDATALEN: that'll error out after the viewname truncation.) In no
> case will the user get left with a table without a view rule, as the
> current code does.
> >
> > Please do so. If you need any help, please let me know.
> > --
> > Tatsuo Ishii
> I haven't tested the MULTIBYTE part. Could you give it a quick once over?
> Ross
> -- 
> Ross J. Reedstrom, Ph.D., <reedstrm(at)rice(dot)edu> 
> NSBRI Research Scientist/Programmer
> Computer and Information Technology Institute
> Rice University, 6100 S. Main St.,  Houston, TX 77005

[ Attachment, skipping... ]

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: Hiroshi InoueDate: 2000-10-15 13:56:12
Previous:From: Bruce MomjianDate: 2000-10-15 03:33:42
Subject: Re: [Solved] SQL Server to PostgreSQL

pgsql-patches by date

Next:From: Bruce MomjianDate: 2000-10-16 03:24:53
Subject: Re: Access PostgreSQL server via SSL/Internet
Previous:From: Philip WarnerDate: 2000-10-15 01:35:43
Subject: Re: src/backend/commands/sequence.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group