> On Tue, Aug 29, 2000 at 10:12:38AM +0900, t-ishii(at)sra(dot)co(dot)jp wrote:
> > > > Oh, the patch strikes me since it is not "multibyte aware."
> O.K. -
> Here's the multibyte aware version of my patch to fix the truncation
> of the rulename autogenerated during a CREATE VIEW. I've modified all
> the places in the backend that want to construct the rulename to use
> the MakeRetrieveViewRuleName(), where I put the #ifdef MULTIBYTE, so
> that's the only place that knows how to construct a view rulename. Except
> pg_dump, where I replicated the code, since it's a standalone binary.
> The only effect the enduser will see is that views with names len(name)
> > NAMEDATALEN-4 will fail to be created, if the derived rulename clases
> with an existing rule: i.e. the user is trying to create two views with
> long names whose first difference is past NAMEDATALEN-4 (but before
> NAMEDATALEN: that'll error out after the viewname truncation.) In no
> case will the user get left with a table without a view rule, as the
> current code does.
> > Please do so. If you need any help, please let me know.
> > --
> > Tatsuo Ishii
> I haven't tested the MULTIBYTE part. Could you give it a quick once over?
> Ross J. Reedstrom, Ph.D., <reedstrm(at)rice(dot)edu>
> NSBRI Research Scientist/Programmer
> Computer and Information Technology Institute
> Rice University, 6100 S. Main St., Houston, TX 77005
[ Attachment, skipping... ]
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
In response to
pgsql-hackers by date
|Next:||From: Bruce Momjian||Date: 2000-09-12 04:30:12|
|Subject: Re: disallow LOCK on a view|
|Previous:||From: Martin A. Marques||Date: 2000-09-11 21:42:29|
|Subject: Re: problems with GRANT on Solaris 8|
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2000-09-12 04:16:57|
|Subject: Re: [PATCHES] JDBC Patch|
|Previous:||From: Bruce Momjian||Date: 2000-09-12 04:12:41|
|Subject: Re: Update tests/regress/resultmap for IRIX 6|