Re: [HACKERS] DROP TABLE inside a transaction block

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Ross J(dot) Reedstrom" <reedstrm(at)wallace(dot)ece(dot)rice(dot)edu>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] DROP TABLE inside a transaction block
Date: 2000-03-09 02:00:56
Message-ID: 200003090200.VAA08228@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > > Most problems where code that used RelationGetPhysicalRelationName
> > > when they it should use RelationGetRelationName. In several cases,
> > > the code assumed RelationGetPhysicalRelationName handed them a
> > > pointer to rd_rel->relname, which they copy into! I substituted
> > > RelationGetRelationName for all these cases.
> >
> > Please send in a patch on those if they need to be corrected, OK?
> >
>
> Once I'm sure it's the Right Thing To Do, I will. That's probably
> the only clean part of the ugly hack I've done so far.

I was just really interested in places where
RelationGetPhysicalRelationName() and RelationGetRelationName() where
called incorrectly. That can go into 7.0.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ed Loehr 2000-03-09 04:24:24 Re: [HACKERS] Transaction abortions & recovery handling
Previous Message Tatsuo Ishii 2000-03-09 01:10:11 Re: [HACKERS] regex (from TODO)