Re: [HACKERS] xlog.c.patch for cygwin port.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: yutaka tanida <yutaka(at)marin(dot)or(dot)jp>, Alexei Zakharov <A(dot)S(dot)Zakharov(at)inp(dot)nsk(dot)su>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] xlog.c.patch for cygwin port.
Date: 2000-03-08 01:50:07
Message-ID: 200003080150.UAA07499@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > This looks interesting. We could remove some of our ifwin cruft.
>
> I have been thinking for quite some time that most of the CYGWIN32
> ifdefs represent very poor programming. Instead of zillions of
>
> #ifndef __CYGWIN32__
> fd = open(filename, O_RDONLY, 0666);
> #else
> fd = open(filename, O_RDONLY | O_BINARY, 0666);
> #endif
>
> we should have in one include file something like

Do we ever assign a function pointer for open() anywhere. If so, the
define will not work without some kind of wrapper, right?

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2000-03-08 01:51:34 Re: [HACKERS] DROP TABLE inside a transaction block
Previous Message Bruce Momjian 2000-03-08 01:48:51 Re: [HACKERS] DROP TABLE inside a transaction block