Re: invalid data in file backup_label problem on windows

From: David Steele <david(at)pgmasters(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: invalid data in file backup_label problem on windows
Date: 2021-03-26 18:45:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 3/26/21 1:20 PM, Magnus Hagander wrote:
> On Fri, Mar 26, 2021 at 5:52 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> On 3/26/21 10:19 AM, David Steele wrote:
>>>> No, the problem is you are using copy/paste and in doing so you are
>>>> *changing'* the value that is being returned. You'll either need to
>>>> update your copy/paste procedure to not mess with the newlines, or to
>>>> use a better way to get the data out.
>>>> If we need to clarify that in the documentation, I'm fine with that.
>>>> Maybe add an extra sentence to the part about not modifying the output
>>>> to mention that this includes changing newslines and also encoding
>>>> (which would also break it, if you managed to find a non-ascii
>>>> compatible encoding). Maybe even something along the line of "the
>>>> contents have to be written in binary mode"?
>>> Perhaps something like the attached?
>> That seems a bit opaque. Let's tell them exactly what they need to avoid.
> Yeah, it seems a bit imprecise. Maybe something like "which includes
> things like opening the file in binary mode"? (I want the "includes"
> part because it also means other things, this is not the only thing).

OK, how about the attached?


Attachment Content-Type Size
backup-binary-mode-v2.patch text/plain 699 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Sven Klemm 2021-03-26 18:56:54 [PATCH] Allow CustomScan nodes to signal projection support
Previous Message legrand legrand 2021-03-26 18:27:02 Re: Query about pg asynchronous processing support