Re: pg_upgrade fails with non-standard ACL

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Arthur Zakirov <zaartur(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails with non-standard ACL
Date: 2020-04-06 16:40:39
Message-ID: 1fb0fb8d-0857-382a-6198-392df6472125@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06.04.2020 16:49, Anastasia Lubennikova wrote:
> New version of the patch is attached. I fixed several issues in the
> check_for_changed_signatures().
>
> Now it passes check without "test_rename_catalog_objects" and fails
> (generates script) with it. Test script pg_upgrade_ACL_test.sh
> demonstrates this.
>
> The only known issue left is the usage of pg_identify_object(), though
> I don't see a problem here with object types that this patch involves.
> As I updated the code, I will leave this patch in Need Review.
>
One more fix for free_acl_infos().
Thanks to cfbot.

--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
pg_upgrade_ACL_check_v8.patch text/x-patch 14.2 KB
pg_upgrade_ACL_test.sh application/x-shellscript 3.1 KB
test_rename_catalog_objects text/plain 49.0 KB
test_add_acl_to_catalog_objects.sql application/sql 436 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-04-06 16:54:56 Re: [HACKERS] Restricting maximum keep segments by repslots
Previous Message Dmitry Dolgov 2020-04-06 16:39:41 Re: Index Skip Scan