Re: pgsql: Add function to log the memory contexts of specified backend pro

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add function to log the memory contexts of specified backend pro
Date: 2025-05-03 01:53:58
Message-ID: 1e837d9f-d32d-4096-b408-fdea3db181cb@oss.nttdata.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2025/05/02 14:58, torikoshia wrote:
> I confirmed that with this patch applied, the process no longer crashes even after applying the change Robert used to trigger the crash.
>
> a small nitpick:
>
> +                * requested  repeatedly and rapidly, potentially leading to infinite
>
> It looks like there are two spaces between "requested" and "repeatedly".

Thanks for the review and testing! I've fixed the issue you pointed out.
Updated patch attached.

Since git cherry-pick didn't work cleanly for v16 and earlier,
I've also prepared a separate patch for those versions.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
v2-0001-PG14-PG16-Add-guard-to-prevent-recursive-memory-contexts-lo.patch text/plain 3.8 KB
v2-0001-PG17-master-Add-guard-to-prevent-recursive-memory-contexts-lo.patch text/plain 3.9 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2025-05-03 10:26:13 pgsql: Fix typos in comments.
Previous Message Bruce Momjian 2025-05-03 00:10:35 pgsql: doc PG 18 relnotes: adjust libpq trace & potocol version items

Browse pgsql-hackers by date

  From Date Subject
Next Message Sutou Kouhei 2025-05-03 02:19:58 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message Bruce Momjian 2025-05-03 00:06:41 Re: PG 18 release notes draft committed