From: | Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
Subject: | [PATCH] Add search front-end from pgweb |
Date: | 2023-08-10 09:10:17 |
Message-ID: | 1d65043e-ef91-77d0-0c2f-2c51af5af1e5@cmatte.me |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
Here's the patch for moving pgweb's search front-end to pgarchives.
I worked on factorizing code between the search API and pgweb's search to avoid code duplication.
I removed the possibility to search for lists using the 'ln=somelist,someotherlist' syntax because it only existed in the search API and did not seem to be used by the code calling this API.
I kept the cache for the front-end search only because it was easier that way. I may be interesting to cache the API as well. What do you think?
Once this is integrated, there is only a few work left to allow searching in private archives, taking access rights into account.
On 02/08/2023 08:46, Magnus Hagander wrote:
>
>
> On Mon, Jul 31, 2023, 11:55 Célestin Matte <celestin(dot)matte(at)cmatte(dot)me <mailto:celestin(dot)matte(at)cmatte(dot)me>> wrote:
>
> I deployed pgarchives and pglister using a custom application for the auth system.
> Now we just noticed that the search function did not work because the frontend is deported to pgweb, and pgarchives only provides a json API.
> What is the rationale behind this? Would it make sense to move the frontend to pgarchives and send a patch here?
>
>
>
>
>
> The rationale behind it is simply that it makes it possible to make a better experience for the user of the pgweb site. (and it used to be even worse from this perspective - pgweb used to open a postgres connection directly into the archives db and query it). So I don't think we want to move that.
>
> That's not a reason to not also have an interface for it in the archives code itself. It just needs to be made configurable in a way that would allow both use cases.
>
>
> /Magnus
>
--
Célestin Matte
Attachment | Content-Type | Size |
---|---|---|
0001-Add-search-front-end-from-pgweb.patch | text/x-patch | 23.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter-Paul Gras | 2023-08-10 14:12:56 | RE: PostgreSQL 15.4, 14.9, 13.12, 12.16, 11.21, and PostgreSQL 16 Beta 3 Released! |
Previous Message | Joe Conway | 2023-08-07 12:41:09 | Re: Wiki editor request |