Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT
Date: 2018-09-14 01:53:05
Message-ID: 1d3837d8-1722-54bb-9df3-19ae5158dc88@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2018/09/13 23:13, Tom Lane wrote:
> Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> On 2018/09/13 1:14, Tom Lane wrote:
>>> That seems excessively restrictive. Anything that has storage (e.g.
>>> matviews) ought to be truncatable, no?
>
>> Not by heap_truncate it seems. The header comment of heap_truncate says
>> that it concerns itself only with ON COMMIT truncation of temporary tables:
>
> Ah. Well, in that case I'm OK with just a simple test for
> RELKIND_RELATION, but I definitely feel that it should be inside
> heap_truncate. Callers don't need to know about the limited scope
> of what that does.

I guess you meant inside heap_truncate_one_rel. I updated the patch that
way, but I wonder if we shouldn't also allow other relkinds that have
storage which RelationTruncate et al can technically deal with.

Thanks,
Amit

Attachment Content-Type Size
heap-truncate-check-relkind-v3.patch text/plain 445 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-09-14 02:02:56 Re: Allowing printf("%m") only where it actually works
Previous Message Michael Paquier 2018-09-14 01:07:59 Re: Loaded footgun open_datasync on Windows