From: | Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> |
---|---|
To: | PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org> |
Subject: | [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True |
Date: | 2022-01-28 17:37:37 |
Message-ID: | 1d060463-e562-7783-decd-b5a7f3c4c06c@cmatte.me |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
pglister_sync.py is a script used to synchronize things between pglister and pgarchives: lists, subscribers etc.
subscriber_access is not set in pglister_sync's query, and is set to null=False in Django's model. As a consequence, pglister_sync fails to add new lists:
Traceback (most recent call last):
File "/srv/pgarchives/local/loader/pglister_sync.py", line 68, in <module>
'groupname': l['group']['groupname'],
psycopg2.errors.NotNullViolation: null value in column "subscriber_access" violates not-null constraint
DETAIL: Failing row contains (8, test-pglister-sync, test-pglister-sync, , t, 1, null).
I don't know if there is a way to configure postgres to use the default value , but I think it would be wiser to explicitly set this variable in pglister_sync.py.
By default, subscriber_access is set to False and there is no way to modify that within the web interface.
As a consequence, access to lists on private servers is restricted to superusers, and there is no easier way to modify that than to edit the database manually.
It seems more logical to me that this value be set to True by default, as access can still be moderated to avoid lists being publicly available.
That said, it may be better to have a way to modify that within the web interface in pglister.
--
Célestin Matte
Attachment | Content-Type | Size |
---|---|---|
0001-pglister_sync-import-lists-with-subscriber_access-se.patch | text/x-patch | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Célestin Matte | 2022-01-28 17:43:01 | Re: [PATCH] pgarchives: pglister_sync: import lists with subscriber_access set to True |
Previous Message | Eric Feng | 2022-01-27 06:30:43 | Re: Wiki editor request |