| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Subject: | Re: bad logging around broken restore_command |
| Date: | 2020-11-20 06:45:10 |
| Message-ID: | 1b959eb8-90f2-8e4f-5d18-eb8bd9cd8633@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/11/19 20:27, Pavel Borisov wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
>
> I decided to add my review to this simple patch.
> I applied Fuji's patch and found it perfectly working with installcheck-world passed, code is clean.
> As for the feature I agree with Jeff and Fuji that this ENOENT case is worth logging under LOG priority.
> I consider the last (Fuji's) patch is now ready to be committed.
Thanks for the review! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2020-11-20 06:51:52 | Re: Asynchronous Append on postgres_fdw nodes. |
| Previous Message | Michael Paquier | 2020-11-20 06:31:22 | Re: don't allocate HashAgg hash tables when running explain only |