Re: BUG #15631: Generated as identity field in a temporary table with on commit drop corrupts system catalogs

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, dnsl48(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15631: Generated as identity field in a temporary table with on commit drop corrupts system catalogs
Date: 2019-04-26 13:07:54
Message-ID: 1a7ee3de-f450-606f-5c89-39e45c8052f8@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2019-04-25 02:59, Michael Paquier wrote:
> Is there something else you are considering for this patch? This
> previous suggestion looks fine to live with, at least for me. Tom,
> perhaps you have some extra input on the matter and would prefer a
> more restrictive location for the CCI?

I didn't find that solution very principled either. I now think the
best fix is to have a CCI at the end of standard_ProcessUtility(). It's
very possible that other commands could also create catalog entries that
some on-commit action would like to see. It wouldn't be sensible to
chase down each command separately.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v3-0001-Fix-potential-catalog-corruption-with-temporary-i.patch text/plain 1.5 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Flo Rance 2019-04-26 13:43:21 Re: Reg: Postgresql8.3 Using on Ubuntu
Previous Message neelaveni 2019-04-26 12:44:13 Re: Reg: Postgresql8.3 Using on Ubuntu