Re: BUG #15788: 'pg_dump --create' orders database GRANTs incorrectly

On 5/21/19, 11:26 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> On Mon, May 20, 2019 at 10:37:50PM +0000, Bossart, Nathan wrote:
>> On 5/20/19, 1:27 AM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
>>> I had first a hard time parsing the subqueries added, so I have
>>> tweaked your patch with more indentation, and a comment block with
>>> more details about why we need to preserve the ACL ordering (you will
>>> note that I don't have a lot of imagination here).
>>
>> Thanks. Your version looks good to me.
>
> Okay, I have done more tests, checks and tweaks on this stuff, and
> pushed the fix for databases down to 9.6.

Thanks!

> The problem comes from dumpTablespaces() which still has a broken ACL
> ordering logic. I'll start a new thread about that as this thread is
> actually now fixed. It would be interesting to refactor all that
> stuff, but I'd like to think that it would be much more interesting if
> we could get pg_init_privs to work with databases and tablespace
> instead, but that would not be back-patchable. So I'll focus on the
> bug fix.

I'll take a look at this.

Nathan