From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Pedro J(dot) Lobo" <pjlobo(at)euitt(dot)upm(dot)es>, PostgreSQL bugs mailing list <pgsql-bugs(at)postgreSQL(dot)org>, PostgreSQL ports mailing list <pgsql-ports(at)postgreSQL(dot)org> |
Subject: | Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc |
Date: | 1999-10-08 17:07:40 |
Message-ID: | 199910081707.NAA28719@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-ports |
> "Pedro J. Lobo" <pjlobo(at)euitt(dot)upm(dot)es> writes:
> > Someone has changed the "#if defined(__alpha)" tests that existed in
> > include/storage/s_lock.h in 6.5.1 to "#if defined(__alpha__)". The problem
> > is that DEC (Compaq?) C only defines __alpha, (gcc defines both __alpha
> > and __alpha__) so it doesn't work anymore.
>
> I thought that was bogus when it was done. Should be
> #if defined(__alpha) || defined(__alpha__)
> to cover both compilers.
>
> > In fact, there are two places where the test is used, one inside a "#if
> > defined(__GNUC__)" and the other one inside the corresponding "#else". It
> > seems that the easiest sollution is to change the check inside the "#else"
> > back to "#if defined(__alpha)".
>
> ... which would break whichever compiler is being used by the person who
> submitted the patch. I don't think it was changed on a whim.
I recommend putting something in the alpha template to define __alpha,
so we don't have to double-compare everywhere. I will make the change
now.
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1999-10-08 17:14:10 | Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc |
Previous Message | Bruce Momjian | 1999-10-08 16:13:38 | Re: [BUGS] 6.5.2 BUG: Rolling back after dropping a table causes dangling relationships. |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1999-10-08 17:14:10 | Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc |
Previous Message | Bruce Momjian | 1999-10-08 16:18:24 | Re: [PORTS] postgresql-6.5.2/src/interfaces/odbc/gpps.h |