From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | ridderbusch(dot)pad(at)sni(dot)de (Frank Ridderbusch) |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] Portability Issue in src/backend/port/snprintf.c (I think) |
Date: | 1998-10-07 17:14:07 |
Message-ID: | 199810071714.NAA02118@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Hi,
>
> I compiled Sundays snapshot in preparation of a SVR4/SINIX Readme. A
> couple of the problems, which I saw, have already been addressed by
> the recent UnixWare patch.
>
> Admittedly my operating system platform is somewhat old, however I
> would think, that there are more os versions out there, which don't
> have a 'long long' data type.
>
> In particular my compiler didn't like the following line in
> src/backend/port/snprintf.c:
>
> /* IRIX doesn't do 'long long' in va_arg(), so use a typedef */
> typedef long long long_long;
>
> I'm on a simple 32bit architecture with no long long support, so I
> changed 'long long' to 'long' and everything was okay.
Good point.
I have fixed snprintf.c so it properly works on machines that don't do
'long long'. I used HAVE_LONG_INT_64 defines around the proper areas.
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1998-10-07 17:56:18 | Re: [HACKERS] RE: [GENERAL] Long update query ? (also Re: [GENERAL] CNF vs. DNF) |
Previous Message | Horak Daniel | 1998-10-07 12:03:35 | NT port of PGSQL - success |