Re: CIDR/IP types. Was: [GENERAL] big numbers

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: tih(at)nhh(dot)no (Tom Ivar Helbekkmo)
Cc: hackers(at)postgreSQL(dot)org (PostgreSQL-development)
Subject: Re: CIDR/IP types. Was: [GENERAL] big numbers
Date: 1998-10-03 05:46:33
Message-ID: 199810030546.BAA09283@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Merged into the current source tree. Please test.

> Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> writes:
>
> > Is this the version you want me to install in the current source tree?
>
> Yup. It seems to work right, so it's what I'm using right now. As
> soon as I've got an IPV6 kit installed here, I'll expand it with code
> to handle that data type -- as you can see, I've left comments all
> over the code showing what needs to be done for that. I reckon the
> thing to do is for you to get it properly into the tree, and then I'll
> do further maintenance on that code, and send patches.
>
> The SQL code to set up indexing capability doesn't work after your
> changes to add OIDs to various names, but I guess that's irrelevant
> when you integrate it into the base system, right? As for the MAC
> level ethernet address stuff, if you want to add that as well, I guess
> we should consider replacing the hard-coded table of manufacturers
> with a table in template1 -- that is the SQL way, after all. Also,
> the names of these types should maybe be changed? I use "ipaddr" and
> "macaddr", but I can't remember if consensus was reached on whether
> the IP address data type should be "cidr", or "inet", or what... If
> you want me to go through the code and change that before you do the
> integration, just let me know.
>
> -tih
> --
> Popularity is the hallmark of mediocrity. --Niles Crane, "Frasier"
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1998-10-03 05:50:24 Re: [HACKERS] Open 6.4 Items
Previous Message Thomas G. Lockhart 1998-10-03 05:23:38 Re: Antwort: Patches for gram.y and keywords.c