Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] union regression test

From: Brook Milligan <brook(at)trillium(dot)NMSU(dot)Edu>
To: lockhart(at)alumni(dot)caltech(dot)edu
Cc: hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] union regression test
Date: 1998-09-21 16:21:52
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
   > 1.  Modify the float8 test so that the table contains exactly the same
   >     values on all platforms.  In this case, this would mean removing
   >     the "extra" rows  that creep in on NetBSD because of the different
   >     handling of small (in absolute value) numbers.  Following this
   >     strategy generally (i.e., in other similar cases) would mean that
   >     all tables could be used at will by "derived" tests without
   >     propagating special cases beyond the direct tests where boundary
   >     cases are critical to include.

   OK, I agree that the first option is probably preferable. But...

   This will ripple across several of the regression tests, and we will
   need to carefully check the changed results in those tests to ensure
   that we understand the changes. We can't just assume that they are due
   to the different input values.

   Also, I would strongly prefer that we keep the internals of the float8
   test the same, so it continues to test edge-effect operations and
   results. Then, at or near the end of the float8 test, empty the table
   and re-insert some better-behaved values (in fact, it could be the same
   values that the table started with probably; I haven't looked).

Absolutely.  That was my intent.  The internal tests should be as
rigorous as possible.  The last thing done would be to leave the table
in a state that is absolutely identical across all platforms.  Yes,
deleting everything and reinserting the well-behaved values seems like
the easiest thing to do.

I don't think anything will ripple much, actually.  The entire point,
though, is to reduce the possible ripple of special cases (after the
correct consistency is guarranteed).  I should have no trouble
recognizing changes, since for me everything passes regression, except
the union test.


In response to


pgsql-hackers by date

Next:From: Thomas G. LockhartDate: 1998-09-21 16:38:24
Subject: Re: [ Re: [HACKERS] BUG: NOT boolfield kills backend]
Previous:From: J. Michael RobertsDate: 1998-09-21 16:18:47
Subject: Re: [ Re: [HACKERS] BUG: NOT boolfield kills backend]

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group