Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?

From: David Geier <geidav(dot)pg(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Lukas Fittl <lukas(at)fittl(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
Date: 2023-02-20 10:36:32
Message-ID: 198ef658-a5b7-9862-2017-faf85d59e3a8@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On 2/14/23 13:48, David Geier wrote:
>
> It still fails.
>
> I'll get Cirrus-CI working on my own Github fork so I can make sure it
> really compiles on all platforms before I submit a new version.

It took some time until Cirrus CI allowed me to run tests against my new
GitHub account (there's a 3 days freeze to avoid people from getting
Cirrus CI nodes to mine bitcoins :-D). Attached now the latest patch
which passes builds, rebased on latest master.

I also reviewed the first two patches a while ago in [1]. I hope we can
progress with them to further reduce the size of this patch set.

Beyond that: I could work on support for more OSs (e.g. starting with
Windows). Is there appetite for that or do we rather want to instead
start with a smaller patch?

[1]
https://www.postgresql.org/message-id/3ac157f7-085d-e071-45fc-b87cd306360c%40gmail.com

--
David Geier
(ServiceNow)

Attachment Content-Type Size
v9-0001-instr_time-Add-INSTR_TIME_SET_SECONDS-INSTR_TIME_.patch text/x-patch 2.0 KB
v9-0002-wip-report-nanoseconds-in-pg_test_timing.patch text/x-patch 11.3 KB
v9-0003-Use-time-stamp-counter-to-measure-time-on-Linux-x.patch text/x-patch 18.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2023-02-20 11:00:00 Re: Killing off removed rels properly
Previous Message shiy.fnst@fujitsu.com 2023-02-20 10:07:51 RE: Allow logical replication to copy tables in binary format