| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mark Kirkwood <markir(at)coretech(dot)co(dot)nz> |
| Cc: | Michael Fuhr <mike(at)fuhr(dot)org>, Pavel Stehule <stehule(at)kix(dot)fsv(dot)cvut(dot)cz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Slow PL/pgSQL 8.0.RC5 (7.4.6. 3times faster) |
| Date: | 2005-01-14 05:15:28 |
| Message-ID: | 19846.1105679728@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mark Kirkwood <markir(at)coretech(dot)co(dot)nz> writes:
> Looks like something introduced between RC1 and RC5:
You mean here
2004-12-19 15:20 tgl
* src/: pl/plpgsql/src/pl_exec.c,
test/regress/expected/plpgsql.out, test/regress/sql/plpgsql.sql:
plpgsql's exec_eval_simple_expr() now has to take responsibility
for advancing ActiveSnapshot when we are inside a volatile
function. Per example from Gaetano Mendola. Add a regression test
to catch similar problems in future.
and here
2004-12-21 13:33 tgl
* src/: pl/plpgsql/src/pl_exec.c,
test/regress/expected/plpgsql.out, test/regress/sql/plpgsql.sql:
exec_eval_simple_expr() needs to do CommandCounterIncrement() not
just GetTransactionSnapshot() to ensure ActiveSnapshot advances
properly. Sigh. Extend regression test so it reveals this error
too.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marc G. Fournier | 2005-01-14 05:53:34 | Re: FATAL: catalog is missing 1 attribute(s) for relid |
| Previous Message | Greg Stark | 2005-01-14 04:50:01 | Re: Bug? 8.0 does not use partial index |