Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pgsql: Refactor flex and bison make rules

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org, Jeremy Drake <pgbuildfarm(at)jdrake(dot)com>
Subject: Re: [HACKERS] pgsql: Refactor flex and bison make rules
Date: 2012-11-28 23:49:52
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 11/28/2012 06:19 PM, Tom Lane wrote:
>> It appears to me that the case that okapi is hitting is specific to the
>> ecpg preprocessor build rules, and indeed specific to the case where
>> preproc.c needs to be rebuilt.  A .NOTPARALLEL in ecpg/preproc/Makefile
>> would probably be enough to fix it.  (I'm a bit tempted to make the one
>> already added to ecpg/Makefile conditional on the make version, as you
>> suggest above, too.)

> There is something odd about okapi, because my linux/gcc buildfarm 
> animal is using make 3.82 happily, with make_jobs = 4.

Yeah, and nobody else has seen this either.  It might just be that okapi
has exactly the right number of processors with exactly the right speeds
to make the failure a lot more probable.  Or maybe there's something
weird about Gentoo's version of make (wouldn't be the first time).

Anyway, deparallelizing just the ecpg/preproc build would cost very
little in build time, since it's totally dominated by the preproc.c and
preproc.o build steps anyway.  I'm inclined to just do it and see if
the problem goes away.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Andres FreundDate: 2012-11-28 23:52:29
Previous:From: Tom LaneDate: 2012-11-28 23:41:39

pgsql-committers by date

Next:From: Tom LaneDate: 2012-11-29 02:26:53
Subject: pgsql: Fix assorted bugs in CREATE/DROP INDEX CONCURRENTLY.
Previous:From: Andrew DunstanDate: 2012-11-28 23:29:56
Subject: Re: [HACKERS] pgsql: Refactor flex and bison make rules

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group