Re: [PATCH] pg_dump: lock tables in batches

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gilles Darold <gilles(at)migops(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: [PATCH] pg_dump: lock tables in batches
Date: 2023-01-03 23:00:37
Message-ID: 1973369.1672786837@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Gilles Darold <gilles(at)migops(dot)com> writes:
> As it seems to have a consensus to apply this patch I will change the
> commitfest status to ready for committers.

Yeah. I still have a nagging worry about why I didn't do this already,
but without evidence I can't fairly block the patch. Hence, pushed.

I did cut the LOCK TABLE query length limit from 1MB to 100K, because
I doubt there is any measurable performance difference, and I'm a
little worried about overstressing smaller servers.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-01-03 23:45:49 Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
Previous Message Karl O. Pinc 2023-01-03 22:43:34 Re: doc: add missing "id" attributes to extension packaging page